Re: [PATCH 00/36] treewide: remove conditional returns with no effect
Jakub Kicinski <[email protected]> Fri, 24 Jul 2026 14:48:22 -0700
| Newsgroups | gmane.comp.freedesktop.xorg.drivers.intel,gmane.comp.freedesktop.amd-gfx,gmane.comp.video.dri.devel,gmane.linux.kernel.cifs,gmane.linux.kernel.clk,gmane.linux.kernel.cryptoapi,gmane.linux.kernel.gpio,gmane.linux.kernel.iio,gmane.linux.kernel.input,gmane.linux.kernel,gmane.linux.drivers.video-input-infrastructure,gmane.linux.kernel.mm,gmane.linux.power-management.general,gmane.linux.drivers.rdma,gmane.linux.scsi,gmane.linux.sound,gmane.linux.usb.general,gmane.linux.kernel.wireless.general,gmane.comp.linux.lvs.devel,gmane.linux.network,gmane.comp.security.firewalls.netfilter.devel,gmane.comp.freedesktop.xorg.nouveau,gmane.linux.drivers.platform.x86.devel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 24 Jul 2026 03:45:02 +0900 Sang-Heon Jeon wrote: > Patch 1 adds a Coccinelle script that matches the pattern, including > negation and constant-comparison variants. Where a local variable is > assigned right before the check, the assignment and the two returns > turn into a single return of the assigned expression. Huh, I thought we already had such script. Various script children have been sending such "cleanups" in the past. > Patches 2-36 are generated by the script, with hand fixes to restore > unexpectedly removed comments and to fix the formatting checkpatch.pl > complained about. Please post patches 4,7,8,9 as a separate series. Since you only CCed netdev on subset of the series patchwork thinks there are patches missing and doesn't kick off any CI.