Re: [PATCH bpf] bpf: Fix netns reference imbalance in conntrack kfuncs
[email protected] Wed, 29 Jul 2026 17:15:20 +0000 (UTC)
| Newsgroups | gmane.comp.security.firewalls.netfilter.devel,gmane.linux.network,gmane.linux.kernel,gmane.linux.kernel.bpf |
|---|---|
| Message-ID | <7aa8b7f7d16fe678e8a66ad5c9888ccee70dd07bd6c40e6a4f456592d33b01ce@mail.kernel.org> |
> The kernel reported: > > Oops: general protection fault, probably for non-canonical address > KASAN: null-ptr-deref in range [0x00000000000000e8-0x00000000000000ef] > RIP: 0010:bpf_prog_test_run_xdp+0x52c/0x1700 > Call Trace: > __sys_bpf+0x1662/0x50c0 > __x64_sys_bpf+0x73/0xb0 > do_syscall_64+0xf9/0x540 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > Kernel panic - not syncing: Fatal exception This isn't a bug, but could the crash trace be clearer about its connection to the fix? The trace shows only BPF test-run frames with no netfilter or conntrack function names visible. The chain is reconstructible - the extra put_net() frees the caller's netns, loopback_dev becomes NULL, and bpf_prog_test_run_xdp() then dereferences it - but a reader has to derive this themselves. Would it help to add a sentence connecting the trace to the fix, or include a Reported-by: or Closes: tag for the original report? --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/30472145413