Re: [PATCH bpf] bpf: Fix netns reference imbalance in conntrack kfuncs

Chengfeng Ye <[email protected]> Thu, 30 Jul 2026 16:30:53 +0800
Newsgroups gmane.linux.kernel.bpf,gmane.comp.security.firewalls.netfilter.devel,gmane.linux.network,gmane.linux.kernel
Message-ID <CAAo+4rWZAdy=6HAHiysb86E5eFmXsWNZACtf_eBzFNqg=9EJhw@mail.gmail.com>
On Thu, Jul 30, 2026 at 2:38 PM Emil Tsalapatis <[email protected]> wrote:
> Sashiko is right on this regarding all other fields of opts having the
> same issue. While they can't lead to a crash, let's still snapshot them
> at the beginning of the function so they don't change from under us.
> This is still far from ideal - we may read an inconsistent snapshot of
> the struct - but it's backed by BPF program-controlled memory so AFAICT
> this is the best we can do.
>
> pw-bot: cr

No problem, v2 was just sent.