Re: [PATCH net v2] net: flow_offload: serialize driver callback lists

Jakub Kicinski <[email protected]> Mon, 3 Aug 2026 16:04:44 -0700
Newsgroups gmane.linux.kernel.stable,gmane.linux.network,gmane.linux.kernel,gmane.comp.security.firewalls.netfilter.devel
Message-ID <[email protected]>
On Sun, 26 Jul 2026 05:03:15 -0700 Weiming Shi wrote:
> Add a flow-offload callback mutex and hold it across direct and indirect
> setup, callback ownership transfer and rollback. Move indirect-unregister
> list removal into the flow-offload core, and keep indirect-device
> registration transactional on setup failure. When TC must reject an
> indirect bind after callback installation, unwind only the callbacks
> created by that bind so existing callbacks remain intact.

Isn't the unbind / rollback stuff mostly orthogonal to the locking?
Looks like the patch should be split.