Re: [PATCH net 03/10] netfilter: ipset: rework cidr bookkeeping
Florian Westphal <[email protected]> Wed, 5 Aug 2026 21:17:51 +0200
| Newsgroups | gmane.comp.security.firewalls.netfilter.devel,gmane.linux.network |
|---|---|
| Message-ID | <[email protected]> |
Pablo Neira Ayuso <[email protected]> wrote: > Florian needs these starter ipset patches to follow with more fixes to > move ipset hash to use rhashtable. > > For his workflow, he considers it better to do this incrementally. Some things I can squash and resend, but in other cases it would indeed be better to keep it extra to avoid too large commits and better document which patch is fixing what issue. Many of these (new) LLM findings have root causes in older, different problems. > While this is not perfect, we prefer this path to address the existing > issues that LLMs have reported in ipset. Yes, we continue to get bug reports in code that is on the chopping block, so the more I changes I have to squash and then send new version the longer it will take to get the real conversion patches in. Around half of the LLM issues I already knew and deliberately did not fix in this first series to keep diff size smaller. Paolo linked to an unrelated patch having a 'sashiko: ' comment in the diffstat section to suppress known benign reports, I will try to remember and make use of this for future submissions that have known warts.