Re: [PATCH] selftests: netfilter: Remove unused variables in conntrack_dump_flush
Fernando Fernandez Mancera <[email protected]>
| Newsgroups | gmane.linux.network,gmane.comp.security.firewalls.netfilter.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/6/26 10:45 AM, Fernando Fernandez Mancera wrote: > On 8/6/26 9:50 AM, Qingshuang Fu wrote: >> From: Qingshuang Fu <[email protected]> >> >> The variables 'rplnlh' in conntrack_data_insert() and 'rplnlh' together >> with 'nest' in conntracK_count_zone() and conntrack_flush_zone() were >> declared but never used since they were introduced. >> >> Similarly, commit 76342e842587 ("selftests: netfilter: remove unused >> parameter") removed the unused 'err' variable from these functions but >> overlooked the remaining unused 'rplnlh' and 'nest' variables. Remove >> them to clean up the code. >> >> Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone") >> Signed-off-by: Qingshuang Fu <[email protected]> >> --- > > Thanks for patch, it looks good to me but could we avoid the fixes tag > here? > > Reviewed-by: Fernando Fernandez Mancera <[email protected]> Actually, since you are at it.. could you also include the following diff? Thanks! --- a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c +++ b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c @@ -216,7 +216,7 @@ static int count_entries(const struct nlmsghdr *nlh, void *data) return MNL_CB_OK; } -static int conntracK_count_zone(struct mnl_socket *sock, uint16_t zone) +static int conntrack_count_zone(struct mnl_socket *sock, uint16_t zone) { char buf[MNL_SOCKET_BUFFER_SIZE]; struct nlmsghdr *nlh;