Re: [PATCH nf] netfilter: ipset: let destroy callbacks adjust ext mem size
Florian Westphal <[email protected]>
| Newsgroups | gmane.comp.security.firewalls.netfilter.devel |
|---|---|
| Message-ID | <[email protected]> |
Florian Westphal <[email protected]> wrote: > For bitmap this change makes no difference, because destructors are > called synchronously. > List type however calls them via call_rcu() so accounting decrement can > happen after list_set_flush() set ext_size to 0. > > 'set->elements = 0' can be removed for the same reason in the list type > case, it calls 'set->elements--' for each element. > > Fixes: 9e41f26a505c ("netfilter: ipset: Count non-static extension memory for userspace") > Suggested-by: Jozsef Kadlecsik <[email protected]> > Signed-off-by: Florian Westphal <[email protected]> > --- > sashiko: list_set_uadd() may call list_set_replace() and > then erronously increments set->elements, causing a counter > drift. This bug will be resolved in a different patch. Seems sashiko ignored this and reported this bug again. The report can thus be discarded.