Re: [PATCH nf] netfilter: ipset: fix list type element drift bug

On Sun, Aug 09, 2026 at 04:16:32PM +0200, Florian Westphal wrote:
> Jozsef Kadlecsik <[email protected]> wrote:
> > Acked-by: Jozsef Kadlecsik <[email protected]>
> 
> Thanks for reviewing!
> 
> > > +	if (n) {
> > >  		list_set_replace(set, e, n);
> > > +		return 0;
> > > +	}
> > > +
> > >  	else if (next)
> > >  		list_add_tail_rcu(&e->list, &next->list);
> 
> While it makes no difference from correctness, the
> above looks very weird, so I propose to turn the else if into plain if (next).
> 
> (Did not spot it before sending...).

For the record: I mangled the patch to remove this else when applying
this. No need to resend.