Re: [nft PATCH 0/2] tests: shell: Keep dumps with numeric protocol values

Florian Westphal <[email protected]>
Newsgroups gmane.comp.security.firewalls.netfilter.devel
Message-ID <[email protected]> 
Phil Sutter <[email protected]> wrote:
> Adjust the test wrapper to create dumps with --numeric-protocol option
> (patch 1) and update all dumps (patch 2).
> 
> One could also set --stateless, py test suite does that, too. Though
> there are tests (in packetpath dir) which seem to rely upon counter or
> other stateful data to be matched in dump files, so keep state for now.

Yes, there are tests that rely on dump validation to catch
non-matching/matching rules; those would have to be switched over to
test for the counter values manually.

Patch LGTM, thanks for working on this.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.