Re: [nft PATCH 0/2] tests: shell: Keep dumps with numeric protocol values

On Thu, Aug 13, 2026 at 02:27:34PM +0200, Florian Westphal wrote:
> Phil Sutter <[email protected]> wrote:
> > Adjust the test wrapper to create dumps with --numeric-protocol option
> > (patch 1) and update all dumps (patch 2).
> > 
> > One could also set --stateless, py test suite does that, too. Though
> > there are tests (in packetpath dir) which seem to rely upon counter or
> > other stateful data to be matched in dump files, so keep state for now.
> 
> Yes, there are tests that rely on dump validation to catch
> non-matching/matching rules; those would have to be switched over to
> test for the counter values manually.

I was looking into that at first but decided to drop the --stateless
flag for now instead. I'd rather implement a way for test cases to
specify they want the stateful output, similar to the feature
requirement.

Or we just leave things as-is, the stateful output is harmless anyway.

> Patch LGTM, thanks for working on this.

Thanks for the review, I'll push it out.

Cheers, Phil