[PATCH nf-next 3/4] netfilter: x_tables: do not print specified table
Pablo Neira Ayuso <[email protected]>
| Newsgroups | gmane.comp.security.firewalls.netfilter.devel |
|---|---|
| Message-ID | <[email protected]> |
This is defensive, possibly this string has been already been sanitized but simply print that this match/target extension can only be used for a given table. Signed-off-by: Pablo Neira Ayuso <[email protected]> --- net/ipv4/netfilter/ipt_rpfilter.c | 3 +-- net/ipv6/netfilter/ip6t_rpfilter.c | 2 +- net/netfilter/xt_CONNSECMARK.c | 3 +-- net/netfilter/xt_SECMARK.c | 3 +-- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/net/ipv4/netfilter/ipt_rpfilter.c b/net/ipv4/netfilter/ipt_rpfilter.c index 6d9bf5106868..2c38fd6624aa 100644 --- a/net/ipv4/netfilter/ipt_rpfilter.c +++ b/net/ipv4/netfilter/ipt_rpfilter.c @@ -95,8 +95,7 @@ static int rpfilter_check(const struct xt_mtchk_param *par) if (strcmp(par->table, "mangle") != 0 && strcmp(par->table, "raw") != 0) { - pr_info_ratelimited("only valid in \'raw\' or \'mangle\' table, not \'%s\'\n", - par->table); + pr_info_ratelimited("only valid in \'raw\' or \'mangle\' table\n"); return -EINVAL; } diff --git a/net/ipv6/netfilter/ip6t_rpfilter.c b/net/ipv6/netfilter/ip6t_rpfilter.c index 67c87a88cde4..af8d10d49de8 100644 --- a/net/ipv6/netfilter/ip6t_rpfilter.c +++ b/net/ipv6/netfilter/ip6t_rpfilter.c @@ -118,7 +118,7 @@ static int rpfilter_check(const struct xt_mtchk_param *par) if (strcmp(par->table, "mangle") != 0 && strcmp(par->table, "raw") != 0) { - pr_info_ratelimited("only valid in \'raw\' or \'mangle\' table, not \'%s\'\n", + pr_info_ratelimited("only valid in \'raw\' or \'mangle\' table\n", par->table); return -EINVAL; } diff --git a/net/netfilter/xt_CONNSECMARK.c b/net/netfilter/xt_CONNSECMARK.c index 1494b3ee30e1..4e4436a9104b 100644 --- a/net/netfilter/xt_CONNSECMARK.c +++ b/net/netfilter/xt_CONNSECMARK.c @@ -87,8 +87,7 @@ static int connsecmark_tg_check(const struct xt_tgchk_param *par) if (strcmp(par->table, "mangle") != 0 && strcmp(par->table, "security") != 0) { - pr_info_ratelimited("only valid in \'mangle\' or \'security\' table, not \'%s\'\n", - par->table); + pr_info_ratelimited("only valid in \'mangle\' or \'security\' table\n"); return -EINVAL; } diff --git a/net/netfilter/xt_SECMARK.c b/net/netfilter/xt_SECMARK.c index 5bc5ea505eb9..38e8e410b4e8 100644 --- a/net/netfilter/xt_SECMARK.c +++ b/net/netfilter/xt_SECMARK.c @@ -79,8 +79,7 @@ secmark_tg_check(const char *table, struct xt_secmark_target_info_v1 *info) if (strcmp(table, "mangle") != 0 && strcmp(table, "security") != 0) { - pr_info_ratelimited("only valid in \'mangle\' or \'security\' table, not \'%s\'\n", - table); + pr_info_ratelimited("only valid in \'mangle\' or \'security\' table\n"); return -EINVAL; } -- 2.47.3