Re: [PATCH 6.1.y 6.6.y] netfilter: nft_set_pipapo: account mapping table allocation
Greg Kroah-Hartman <[email protected]>
| Newsgroups | gmane.linux.kernel.stable,gmane.comp.security.firewalls.netfilter.devel,gmane.linux.network,gmane.linux.kernel |
|---|---|
| Message-ID | <2026083125-bronze-stability-8fba@gregkh> |
On Mon, Aug 31, 2026 at 06:37:55AM +0200, Karl Mehltretter wrote:
> [ Upstream commit 69e687cea79fc99a17dfb0116c8644b9391b915e ]
>
> The pipapo set backend data structure is one of the ruleset objects
> that upstream changed to use GFP_KERNEL_ACCOUNT for memory accounting.
>
> The 6.1.y and 6.6.y adaptations changed the other pipapo allocations,
> but omitted the mapping table allocation in pipapo_realloc_mt() because
> that helper does not exist in these branches. The equivalent allocation
> is in pipapo_resize() and still uses GFP_KERNEL, so the persistent mapping
> table is not charged to the allocating memory cgroup.
>
> Update this allocation to use GFP_KERNEL_ACCOUNT.
>
> Fixes: a0bb39980635 ("netfilter: nf_tables: missing objects with no memcg accounting")
> Fixes: 1c4f72fa9699 ("netfilter: nf_tables: missing objects with no memcg accounting")
> Signed-off-by: Karl Mehltretter <[email protected]>
You lost the original authorship and signed-off-by :(
And it is very different from the original.
Also, why is this needed at all?