prewikka/master: Do not provide an exhaustive list of unreachable linked alert

[email protected] Fri, 3 Jul 2009 10:24:35 +0200 (CEST)
Newsgroups gmane.comp.security.ids.prelude.cvs
Message-ID <[email protected]>
commit b2d13e9ece99085534608a8d08a483add20ce70e
Author: Yoann Vandoorselaere <[email protected]>
Date:   Thu Jul 2 16:45:49 2009 +0200

    Do not provide an exhaustive list of unreachable linked alert
    
    Rather tell the user how many linked alert are not reachable any more.


========================================

 prewikka/views/messagesummary.py |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

========================================

diff --git a/prewikka/views/messagesummary.py b/prewikka/views/messagesummary.py
index db763d9..1582470 100644
--- a/prewikka/views/messagesummary.py
+++ b/prewikka/views/messagesummary.py
@@ -656,17 +656,22 @@ class AlertSummary(TcpIpOptions, MessageSummary, view.View):
         for analyzerid in calist.keys():
 
             content = ""
+            missing = 0
             for ident in calist[analyzerid]:
                 criteria = "alert.analyzer.analyzerid = '%s' && alert.messageid = '%s'" % (analyzerid, ident)
 
                 results = self.env.idmef_db.getAlertIdents(criteria)
                 if len(results) == 0:
-                    content += "<li>" + _("Invalid 'analyzerid:messageid' pair, '%(analyzerid):%(messageid)'") % { "analyzerid": analyzerid, "messageid": ident } + "</li>"
+                    missing += 1
+                    #content += "<li>" + _("Invalid 'analyzerid:messageid' pair, '%(analyzerid):%(messageid)'") % { "analyzerid": analyzerid, "messageid": ident } + "</li>"
                 else:
                     alert = self.env.idmef_db.getAlert(results[0], htmlsafe=True)
                     link = utils.create_link("alert_summary", { "origin": self.parameters["origin"], "ident": results[0] })
                     content += "<li><a href=\"%s\">%s</a></li>" % (link, alert["classification.text"])
 
+            if missing > 0:
+                content += "<li>" + (_("%d linked alerts missing (probably deleted)") % missing) + "</li>"
+
             self.newTableCol(idx, "<ul style='padding: 0px; margin: 0px 0px 0px 10px;'>%s</ul>" % content)
             self.buildAnalyzer(alert["analyzer(-1)"])
             self.newTableRow()
_______________________________________________
Prelude-cvslog site list
[email protected]
http://lists.prelude-ids.org/mailman/listinfo/prelude-cvslog