Re: [Prelude Universal SIM system] #332: Error about missing arguments in prelude-correlator lua ruleset

On Friday 06 February 2009 01:02:41 am Prelude Universal SIM system wrote:
>  After looking at the source code it seems to me that the problem is
>  actually in IDMEF_getraw.  There are circumstances where IDMEF_getraw can
>  return zero values on the stack, thereby causing what looks like:
>
>  {{{
>  diff --git a/plugins/lua/lua-idmef.c b/plugins/lua/lua-idmef.c
>  index ebde74a..09e82c9 100644
>  --- a/plugins/lua/lua-idmef.c
>  +++ b/plugins/lua/lua-idmef.c
>  @@ -320,8 +320,10 @@ static int IDMEF_getraw(lua_State *lstate)
>                   return -1;
>           }
>
>  -        if ( ret == 0 )
>  -                return 0;
>  +        if ( ret == 0 ) {
>  +                lua_pushnil(lstate);
>  +                return 1;
>  +        }
>
>           pushIDMEFValue(lstate, value);
>           return 1;
>  }}}

So, is this patch the official fix for this problem? Should distributions go 
ahead and apply it?

Thanks,
-Steve
_______________________________________________
Prelude-devel site list
[email protected]
http://lists.prelude-ids.org/mailman/listinfo/prelude-devel