Re: Upgrade syslinux to 4.04-pre14 or wait for 4.04?

----- Original Message ----- 
From: "Olaf Westrik" <weizen_42-Yz37vSk3/[email protected]>
To: "Gilles Espinasse" <[email protected]>
Cc: "IPCOP devel" <[email protected]>
Sent: Sunday, April 17, 2011 7:51 PM
Subject: Re: [IPCop-devel] Upgrade syslinux to 4.04-pre14 or wait for 4.04?


> On 2011-04-06 22:55, Gilles Espinasse wrote:
>
> > The issue should be in networking.c after green card selection is
checked.
> > Segmentation fault appear even without manually inserting an isa card.
> > With 3 cards (pci) detected, one set as green and for red none of
(ANALOG,
> > GSM3G, ISDN) is selected, it will segfault.
>
> I tried to install with several options for RED, none caused a seg fault.
> Can you describe the exact steps to reproduce?
>
>
> Olaf

It was segfaulting in the code I added to debug the first issue with ISA
card. ;-(
Once I fixed that, I can only trigger adding an isa card, and selecting a
network color for that card.
Once I have a card in green, a card in red and an isa card anywhere, when I
use the 'done' button, it segfault.
gdb say the first issue is in networking.c:650.
I suppose the issue is with both networks[i].vendorid, networks[i].modelid
as they are not set in manual selection.
That patch fix the segfault
Index: src/installer/networking.c
===================================================================
--- src/installer/networking.c  (revision 5623)
+++ src/installer/networking.c  (working copy)
@@ -251,6 +251,8 @@
             networks[numnetwork].description = strdup(description);
             networks[numnetwork].colour = NONE;
             networks[numnetwork].address =
strdup(getmac(networks[numnetwork].device));
+            networks[numnetwork].vendorid = "";
+            networks[numnetwork].modelid = "";
             fprintf(flog, "  hwlist (ISA/manual) %s device %s MAC %s\n",
module, networks[numnetwork].device, networks[numnetwork].address);

             numnetwork++;

Gilles


------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev