need for static functions declaration (was Re: Fwd: Libnet bug?)
Alessandro Salvatori (sandr8) <[email protected]>
| Newsgroups | gmane.comp.security.libnet |
|---|---|
| Message-ID | <[email protected]> |
if libnet_write_raw_ipv4() were bugged nothing would work. But... why should the user-programmer invoke libnet_write_raw_ipv4()? isn't libnet_adv_cull_packet() provided for that reason? or i am wrong? In the last few weeks, many problems user-programmers and distro-mantainers have shown on this mailng list were related to internal functions... IMHO i think that we should reorganize functions in files. Sure, now file names are very easy and help to find functions in a quick way but if we keep doing it this way people will continue to invoke functions they were told not to use. We should declare STATIC those functions and put our functions that need those functions in the same source file. People will then have less hassles. cheers Alessandro Salvatori On Mon, 26 Jan 2004 05:01:04 -0800 Mike Schiffman <[email protected]> wrote: > Anyone else confirm or deny? > > Begin forwarded message: > > > From: Bucka Andrej <[email protected]> > > Date: January 26, 2004 2:45:17 AM PST > > To: "'[email protected]'" <[email protected]> > > Subject: Libnet bug? > > > > Hello Mike, > > > > the latest stable version of LIBNET (1.1.1) has a problem in the > > libnet_write_raw_ipv4 function. The problem occurrs in SuSE Linux 9.0 - > > written IP packets have always checksum set to 0 value, other parts of > > IP > > datagram have the same values as they were passed to the function (by > > using > > pointer to the preconstructed packet) - they are OK. This problem does > > not > > occur in RedHat 7.3, so it is not caused by my SW. > > > > I thank you for your answer and wish you a nice a day. > > > > Best regards, > > Andrej > > > > > > > > <!DSPAM:4014efd394706339513238> > > > > > > > -- > Mike Schiffman, CISSP > http://www.packetfactory.net/schiffman > Doveryay No Proveryay > > -- sandr8) << [ICQ] 78916545 << [EMAIL] sandr8 /:_<AT>_:\ crocetta.org << << [homepage] http://www.crocetta.org/~sandr8/ << << [GPG public key] http://www.crocetta.org/~sandr8/sandr8.asc