doublecheck_std_services.nasl dependency bug [PATCH]

This is a multi-part message in MIME format.
--------------090602000905050705060108
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

Hi,

on Nessus 2.2.6 and 2.2.7, I noticed the following problem in the log:

[Mon Apr 17 09:08:32 2006][28378] find_service1.nasl (process 28383)
finished its job in 0.007 seconds
[Mon Apr 17 09:08:32 2006][28378] user xyz : Not launching
doublecheck_std_services.nasl against x.x.x.x because the key
Settings/ThoroughTests is missing (this is not an error)


This happened on every scan. Thorough tests was enabled in our nessusrc,
so I couldn't understand why this was happening. We found out that the
key gets set in global_settings.nasl, and double-checked that the value
was being set correctly - it was.

It turns out that global_settings.nasl was always being run *after*
doublecheck_std_services.nasl, so it just wasn't set yet.

Adding a dependency on global_settings.nasl in
doublecheck_std_services.nasl fixed this problem. Patch is attached.

Does this bug not occur in Nessus 3 due to changes in the plugin
scheduling / NASL interpreter?


-- 
Hubert Seiwert

Internet Security Specialist, Westpoint Ltd
Albion Wharf, 19 Albion Street, Manchester M1 5LN, United Kingdom

Web: www.westpoint.ltd.uk
Tel: +44-161-2371028

--------------090602000905050705060108
Content-Type: text/plain;
 name="doublecheck_std_services_nasl.patch.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="doublecheck_std_services_nasl.patch.txt"

--- doublecheck_std_services.nasl	2006-04-21 17:37:42.000000000 +0100
+++ doublecheck_std_services.nasl	2006-04-21 17:37:25.000000000 +0100
@@ -42,7 +42,7 @@
  family["english"] = "Service detection";

  script_family(english:family["english"]);
- script_dependencie("find_service.nes", "find_service1.nasl", "apache_SSL_complain.nasl");
+ script_dependencie("find_service.nes", "find_service1.nasl", "apache_SSL_complain.nasl", "global_settings.nasl");
  script_require_keys("Settings/ThoroughTests");
  exit(0);
 }

--------------090602000905050705060108
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Nessus-devel mailing list
[email protected]
http://mail.nessus.org/mailman/listinfo/nessus-devel
--------------090602000905050705060108--