Re: strace change in nessus-libraries/libnessus/plugutils.c

Michael Scheidell <[email protected]>
Newsgroups gmane.comp.security.nessus.devel
Message-ID <[email protected]>
> I do not think the following change was, ehm, a step in the right
> direction:
> 
> <--snip-->
> diff -u -p -r1.106 -r1.107
> --- nessus-libraries/libnessus/plugutils.c	2003/02/27 10:09:57	1.106
> +++ nessus-libraries/libnessus/plugutils.c	2003/03/03 23:16:01	1.107
> @@ -942,7 +942,7 @@ mark_successful_plugin(desc)
>  
>   bzero(data, sizeof(data));
>   sprintf(data, "Success/%d", id);
> - if(!plug_get_key(desc, data))
> + if(!(desc, data))
>    plug_set_key(desc, data, ARG_INT, (void*)1);

While we are picking on plugutils.c

at line 780, we seem to set the key twice...
was one of them supposdet to read? or set a different key?

  plug_set_key(args, port_s, ARG_INT, (void*)1);
  sprintf(port_s, "/tmp/Ports/%s/%d", proto, portnum);
  plug_set_key(args, port_s, ARG_INT, (void*)1);

>   
>   
> <--snip-->
> 
> --Pavel Kankovsky aka Peak  [ Boycott Microsoft--http://www.vcnet.com/bms ]
> "Resistance is futile. Open your source code and prepare for assimilation."
> 

-- 
Michael Scheidell, CEO
SECNAP Network Security, LLC 
Sales: 866-SECNAPNET / (1-866-732-6276)
Main: 561-368-9561 / www.secnap.net
Looking for a career in Internet security?
http://www.secnap.net/employment/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.