Re: strace change in nessus-libraries/libnessus/plugutils.c

On Thu, May 15, 2003 at 11:27:56AM -0400, Michael Scheidell wrote:
> > I do not think the following change was, ehm, a step in the right
> > direction:
> > - if(!plug_get_key(desc, data))
> > + if(!(desc, data))
> >    plug_set_key(desc, data, ARG_INT, (void*)1);

Fixed. Fortunately, this should be pretty harmless.


> While we are picking on plugutils.c
> 
> at line 780, we seem to set the key twice...
> was one of them supposdet to read? or set a different key?
> 
>   plug_set_key(args, port_s, ARG_INT, (void*)1);
>   sprintf(port_s, "/tmp/Ports/%s/%d", proto, portnum);
>   plug_set_key(args, port_s, ARG_INT, (void*)1);

The key is set twice but with a different name. One is persistent (ie:
if the KB is saved and reloaded it will stay there), one is not
(everything starting with /tmp/ is not saved). This lets the plugin
distinguish between a port which is opened for sure and one which used
to be open, but might not be opened again.


				-- Renaud