[patch] configure.in $XPATH:$PATH IFS=: issue

Martin Mačok <[email protected]>
Newsgroups gmane.comp.security.nessus.devel
Organization DCIT, s.r.o.
Message-ID <[email protected]>
Hi,
there is a bug in configure.in which causes some configure tests to
fail.

Shortly, $IFS in shell works only in 'substitution' phase and not
later, so the colon between $XPATH:$PATH is not used as a separator
then - which means that the last dir in XPATH and the first dir in
PATH stay together.

I recommend reading ksh(1) manpage if you want the details
or test it with:

$ IFS=:
$ VAR="hello:goodbye"
$ for I in $VAR:$VAR ; do echo "XXX $I XXX" ; done
XXX hello XXX
XXX goodbye:hello XXX
XXX goodbye XXX
$

The patch for nessus-core and nessus-plugins 2.0.6a is attached.

P.S. There are some shells where IFS does split goodbye:hello in this
case (namely "bash-1.x" and "zsh") but "ksh" (pdksh) and "bash-2"
doesn't.

-- 
         Martin Maèok                 http://underground.cz/
   [email protected]        http://Xtrmntr.org/ORBman/
nessus-2.0.6a-XPATH.patch (text/plain, 2.3 KB)
--- nessus-core/configure.in.orig	2003-06-09 14:58:15.000000000 +0200
+++ nessus-core/configure.in	2003-06-09 15:00:05.000000000 +0200
@@ -76,7 +76,7 @@
 nessus_lib=-l$nessus
 
 dnl extending the search path for AC_PATH_PROG when searching for config scripts
-XPATH=$DESTDIR$prefix/bin
+XPATH="$DESTDIR$prefix/bin:$PATH"
 	
 
 dnl User options
@@ -117,7 +117,7 @@
 
 
 
-AC_PATH_PROG(NESSUSCONFIG, $nessus-config,,$XPATH:$PATH)
+AC_PATH_PROG(NESSUSCONFIG, $nessus-config,,$XPATH)
 
 test "x$NESSUSCONFIG" = x && AC_ERROR(""
 ""
@@ -125,7 +125,7 @@
 "compile nessus-core."
 "Get it at ftp://ftp.nessus.org/pub/nessus/")
 
-AC_PATH_PROG(NASLCONFIG, $nasl-config,,$XPATH:$PATH)
+AC_PATH_PROG(NASLCONFIG, $nasl-config,,$XPATH)
 
 test "x$NASLCONFIG" = x &&  AC_ERROR(""
 ""
@@ -636,16 +636,16 @@
 fi
 
 
-AC_PATH_PROG(GTKCONFIG, gtk-config,,$XPATH:$PATH)
+AC_PATH_PROG(GTKCONFIG, gtk-config,,$XPATH)
 test "x$GTKCONFIG" = x && {
-	AC_PATH_PROG(GTKCONFIG, gtk12-config,,$XPATH:$PATH)
-	test "x$GTKCONFIG" = x && AC_PATH_PROG(GTKCONFIG, gtk10-config,,$XPATH:$PATH)
+	AC_PATH_PROG(GTKCONFIG, gtk12-config,,$XPATH)
+	test "x$GTKCONFIG" = x && AC_PATH_PROG(GTKCONFIG, gtk10-config,,$XPATH)
 	}
 	
 	
 	
 test "$GTKCONFIG" || {
-  AC_PATH_PROG(PKGCONFIG, pkg-config,,$XPATH:$PATH)
+  AC_PATH_PROG(PKGCONFIG, pkg-config,,$XPATH)
   test -z "$PKGCONFIG" &&
 	AC_WARN("**** gtk-config not found.")
 }
@@ -666,9 +666,9 @@
 
 test -n "$GTKCONFIG" && 
 {
-AC_PATH_PROG(GLIBCONFIG, glib-config,,$XPATH:$PATH)
+AC_PATH_PROG(GLIBCONFIG, glib-config,,$XPATH)
 test "x$GLIBCONFIG" = x && {
-       AC_PATH_PROG(GLIBCONFIG, glib12-config,,$XPATH:$PATH)
+       AC_PATH_PROG(GLIBCONFIG, glib12-config,,$XPATH)
        }
 }
 
--- nessus-plugins/configure.in.orig	2003-06-09 14:58:15.000000000 +0200
+++ nessus-plugins/configure.in	2003-06-09 15:00:17.000000000 +0200
@@ -38,7 +38,7 @@
 INSTALL_DIR="$INSTALL -d"
 
 dnl extending the search path for AC_PATH_PROG when searching for config scripts
-XPATH=$DESTDIR$prefix/bin
+XPATH="$DESTDIR$prefix/bin:$PATH"
 
 
 
@@ -59,7 +59,7 @@
 dnl this library is deprecated because of portability
 AC_CHECK_LIB(util, openpty, LIBUTIL="-lutil")
 
-AC_PATH_PROG(NESSUSCONFIG, $nessus-config,,$XPATH:$PATH)
+AC_PATH_PROG(NESSUSCONFIG, $nessus-config,,$XPATH)
 
 test "x$NESSUSCONFIG" = x && AC_ERROR(""
 ""
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.