Re: Re: nessus-core/nessus/prefs_dialog prefs_plugins.c, 1.45.4.2, 1.45.4.3

Jan-Oliver Wagner <[email protected]> Mon, 7 Feb 2005 17:48:18 +0100
Newsgroups gmane.comp.security.nessus.devel
Message-ID <[email protected]>
On Mon, Feb 07, 2005 at 05:07:31PM +0100, Jan-Oliver Wagner wrote:
> On Mon, Feb 07, 2005 at 10:27:26AM -0500, Renaud Deraison wrote:
> > On Mon, Feb 07, 2005 at 10:39:20AM +0100, Jan-Oliver Wagner wrote:
> > > IIUC this change removes, apart from some "if 0"-deactivated code,
> > > the "Upload Plugin" feature from the client.
> > > 
> > > Should I remove the "Upload Plugin" feature from 
> > > CVS HEAD and the users manual as well?
> > 
> > Yes please. You can also port my list sorting function to sort the
> > plugins names and families in the GUI.
> 
> I will remove the Upload feature entirely from Nessus Client then.

Done now.

There are some superflous functions in plugin_prefs.c in the
2_2 branch. I do not dare to commit something to the stable
branch, so I attached my patch for review.

Best

	Jan
-- 
Jan-Oliver Wagner               http://intevation.de/~jan/

Intevation GmbH                      http://intevation.de/
FreeGIS                                http://freegis.org/

_______________________________________________
Nessus-devel mailing list
[email protected]
http://mail.nessus.org/mailman/listinfo/nessus-devel
prefs_plugins.c.diff (text/plain, 900 B)
Index: prefs_plugins.c
===================================================================
RCS file: /usr/local/cvs/nessus-core/nessus/prefs_dialog/prefs_plugins.c,v
retrieving revision 1.45.4.5
diff -u -3 -p -r1.45.4.5 prefs_plugins.c
--- prefs_plugins.c	7 Feb 2005 01:56:04 -0000	1.45.4.5
+++ prefs_plugins.c	7 Feb 2005 16:46:08 -0000
@@ -56,29 +56,6 @@ static GtkWidget * warning_sign(GtkWidge
 static int glist_cmp( gconstpointer a, gconstpointer b);
 
 
-static int
-file_dialog_hide(GtkWidget * filew, GtkWidget * nul)
-{
- gtk_widget_hide(filew);
- gtk_widget_destroy(filew);
- return 0;
-}
-
-static int
-file_selected(GtkWidget * nul,
-	      GtkWidget * filew)
-{
- char * fname = (char*)gtk_file_selection_get_filename(GTK_FILE_SELECTION(filew));
- gtk_widget_hide(filew);
- 
- comm_plugin_upload(fname);
- return 0;
-}	  
-
-
-
-
-
 static int warning_expl()
 {
  show_info(HLP_WARNING);