Re: Patches for http.lua and adding support in httpspider.lua

Hello Vinamra,
These two changes in http.lua (the redirection path fix and the cookie
management) are not directly related so they should be unbundled.

I definitely agree with the objective of the first change.

On a high level the intent of the latter change materially diverges from
the current contract of the script code being clearly in charge of
managing cookies. Now the HTTP library is competing for this management,
while not implementing it anywhere close to what a proper HTTP user
agent is prescribed to do.

I do get it why you are interested in this change for the sake of the
redirects and the spider but IMHO the broad-reaching implications alone
deserve a discussion.

Please see my inline comments on GitHub for technical feedback on the
implementation of both changes.


Cheers,
nnposter
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/