Patch for repeated downloading of files in http-fetch

Aniket Pandey <[email protected]>
Newsgroups gmane.comp.security.nmap.devel
Message-ID <[email protected]>
Hi list, 

This mail is in relation to the http-fetch NSE script, which has an
issue that it does not check for the presence of a file in the output
table while downloading them. 

This leads to repeated fetching of identical files (as pointed out by
nnposter in https://github.com/nmap/nmap/pull/1105 ). As a result, the
output table looks cluttered. 

I made some fixes for this issue and also refactored the code to make it
more modular as this issue was prevalent in 4 different occasions.  

Kindly have a look at the PR https://github.com/nmap/nmap/pull/1107 . I
verified the patch in all cases I can think of and I believe it works.
Although, if still there is some issue, please comment on the PR and
I'll fix it. 

Thanks and Regards, 

Aniket

_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.