Re: [Passwordsafe-users] Announcing first BETA of PasswordSafe 3.0

On Wed, 08 Mar 2006 16:54:38 -0500, Rony Shapiro <[email protected]> wrote:
>
> After quite a lot of work, PasswordSafe 3.0 is ready for its first public
> release.
>

Congratulations! Good work.

How did you decide on the format of text fields: are they now all in UTF-8?
Can you please add a note to the formatV3.txt document to that effect?

Attached is a small patch to the PWSfileV3::StretchKey() function. In this
context, X is a character pointer, and sizeof(X) is 4, which is probably
not what you wanted.

I am happy to report that Password Gorilla has no problem reading your V3
files (which is all I tested so far).

Thanks,
Frank

-- 
Frank Pilhofer, [email protected]

*** PWSfileV3.cpp.orig	Wed Mar  8 18:55:31 2006
--- PWSfileV3.cpp	Wed Mar  8 18:56:04 2006
***************
*** 350,356 ****
    ASSERT(N >= 2048); // minimal value we're willing to use
    for (unsigned int i = 0; i < N; i++) {
      SHA256 H;
!     H.Update(X, sizeof(X));
      H.Final(X);
    }
  }
--- 350,356 ----
    ASSERT(N >= 2048); // minimal value we're willing to use
    for (unsigned int i = 0; i < N; i++) {
      SHA256 H;
!     H.Update(X, SHA256::HASHLEN);
      H.Final(X);
    }
  }