Inspecting Code for Security

[email protected] Mon, 20 Sep 2004 15:55:35 -0400
Newsgroups gmane.comp.security.programming,gmane.comp.security.basics
Message-ID <9FF0C3F57839B04E964E29EBDB98D4B001223B30@Toroondc911>
I have a background in programming and code inspection. However our inspections were not targeted at security, instead they looked for logic errors, over complex code, missing comments, etc.
 
With security in mind what things other things should I be looking for in a code inspection? I can think of the following, but I'm sure there are others:
 
- buffers that could be overflowed
- ensuring all input is validated (checked to ensure it is of the proper
type & format) 
- ensuring passwords & other encrypted date is not stored unencrypted in memory
- ensuring strong encryption is used
- ensuring no easter eggs / backdoors are left in the code
- ???
 
Thanks