Re: build for s390x system

Hi, 

I investigated the value using the following programs. 

----
#include "stdlib.h"
#include "bignum_fast.h"

int main(int argc, char **argv) {

	printf("fp_digit: %d\n",sizeof(fp_digit));
	printf("unsigned long: %d\n",sizeof(unsigned long));

#ifdef FP_64BIT
	printf("FP_64BIT: %d\n",FP_64BIT);
#else
	printf("FP_64BIT not defined\n");
#endif

#ifdef DIGIT_BIT
	printf("DIGIT_BIT: %d\n",DIGIT_BIT);
#else
	printf("DIGIT_BIT not defined\n");
#endif

#ifdef CHAR_BIT
	printf("CHAR_BIT: %d\n",CHAR_BIT);
#else
	printf("CHAR_BIT not defined\n");
#endif

#ifdef FP_MAX_SIZE
	printf("FP_MAX_SIZE: %d\n",FP_MAX_SIZE);
#else
	printf("FP_MAX_SIZE not defined\n");
#endif

#ifdef FP_SIZE
	printf("FP_SIZE: %d\n",FP_SIZE);
#else
	printf("FP_SIZE not defined\n");
#endif

#ifdef TFM_ASM
	printf("TFM_ASM: defined\n");
#else
	printf("TFM_ASM not defined\n");
#endif

	exit(0);
}
----

The result was as follows. 

fp_digit: 8
unsigned long: 8
FP_64BIT not defined
DIGIT_BIT: 64
CHAR_BIT: 8
FP_MAX_SIZE: 8704
FP_SIZE: 136
TFM_ASM not defined

Can you find a problem by this result? 

Thanks.

--
T.Oyamada

On Mon, 23 Sep 2013 12:56:59 -0400
David Raynor <[email protected]> wrote:

> On Mon, Sep 23, 2013 at 11:00 AM, Tsutomu Oyamada
> <[email protected]>wrote:
> 
> > Hi, all.
> >
> > We are using ClamAV for IBM zLinux (s390x architecture)
> > So many Warnings were output as follows, when we made a new build
> > with using the new release 0.98.
> >
> > # ./configure --prefix=/usr/lib/clamav --exec-prefix=/usr/lib/clamav
> > --bindir=/usr/lib/clamav --sbindir=/usr/lib/clamav --sysconfdir=/etc/clamav
> > --libdir=/usr/lib/clamav --datarootdir=/usr/lib/clamav
> > --with-dbdir=/usr/lib/clamav --disable-clamav --with-zlib=/usr/local
> > --with-libbz2-prefix=/usr/local
> > (snip)
> > # make
> > (snip)
> > tomsfastmath/mul/fp_mul_comba_20.c:91: warning: right shift count >= width
> > of type
> > tomsfastmath/mul/fp_mul_comba_20.c:91: warning: right shift count >= width
> > of type
> > tomsfastmath/mul/fp_mul_comba_20.c:91: warning: right shift count >= width
> > of type
> >
> > And, the binary did not work properly as a result.
> >
> > Is there any special settings in a case of make for s390?
> > Can I have any advice/suggestion?
> >
> > Best Regards,
> > Oyamada
> >
> > _______________________________________________
> > http://lurker.clamav.net/list/clamav-devel.html
> > Please submit your patches to our Bugzilla: http://bugs.clamav.net
> >
> 
> That line (and other ones like it in fp_mul_comba_20.c) are doing
> calculations using an array of elements of type "fp_digit". "fp_digit" is
> defined in libclamav/bignum_fast.h.
> 
> I don't have access to a s390 to test with and I don't see any notes on
> tomsfastmath and s390, so I will need your help to investigate. Can you get
> me some values as calculated by bignum_fast.h?
> 
> 1) Sizes of two types: sizeof(fp_digit), sizeof(unsigned long)
> 2) Values of these defined macros, if defined: FP_64BIT, DIGIT_BIT,
> CHAR_BIT, FP_MAX_SIZE, FP_SIZE, TFM_ASM
> 
> Thanks,
> 
> Dave R.
> 
> -- 
> ---
> Dave Raynor
> Sourcefire Vulnerability Research Team
> [email protected]
> _______________________________________________
> http://lurker.clamav.net/list/clamav-devel.html
> Please submit your patches to our Bugzilla: http://bugs.clamav.net
> 


_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net