Re: [PATCH 1/1] Only bring in <execinfo.h> if it's available
Shawn Webb <[email protected]>
| Newsgroups | gmane.comp.security.virus.clamav.devel |
|---|---|
| Message-ID | <CAO2uJad4zZEaA2-93vU=QTsqawPbr4E4aR2K0Ue9vYSe=e54hg@mail.gmail.com> |
On Mon, Nov 3, 2014 at 2:09 PM, Bernd Kuhls <[email protected]> wrote: > Hi, > > Shawn Webb <[email protected]> wrote in news:CAO2uJaf5EB5O7=5P_ > [email protected]: > > > Thanks for this patch. Can you please file a bug in our bug tracker at > > https://bugzilla.clamav.net/? > > https://bugzilla.clamav.net/show_bug.cgi?id=11170 > Could you please make this bug report public so the buildroot maintainers > can > check it while reviewing my patch? > > > Also, instead of modifying configure (which > > is generated using GNU autotools), can you modify configure.ac instead? > > I oriented myself at this commit > > https://github.com/vrtadmin/clamav- > devel/commit/0f9ce68529b9ebf4011cb9a19ac1210eb3f7d317 > > where I was surprised to see a generated ./configure being part of the git > repo. > > > That way your changes will stick whenever we run autoreconf. The way your > > patch stands right now is that your changes to the configure script would > > get wiped away whenever anyone runs autoreconf. > > This won´t happen because I patched m4/reorganization/headers.m4 ;) Gotcha. Sorry, I had missed that part of the patch. Thanks! _______________________________________________ http://lurker.clamav.net/list/clamav-devel.html Please submit your patches to our Bugzilla: http://bugs.clamav.net http://www.clamav.net/contact.html#ml