Re: Pull request to add parallel scanning to clamscan
Mark Allan <[email protected]>
| Newsgroups | gmane.comp.security.virus.clamav.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, I'm not on the ClamAV development team, so have no say whatsoever in terms of what's accepted and what isn't. That said, this is something I'd *love* to see implemented in clamscan. Thank you! Disclaimer: I'm just having a look at this now but haven't fully read through the diff yet... From the commit message you said "build a list of files first and then spawn N children to scan the files in parallel." Does this actually iterate *all* the files and directories before starting the first scan? If you're scanning a large directory tree, how much overhead does this add prior to scanning the first file? Alternatively, as clamscan already iterates through directories, does it maintain a count of the number of concurrent calls to 'scanfile()' and fire off another one at that point as necessary? Will take a closer look later, and maybe even answer my own questions :) Mark > On 20 Jun 2017, at 9:46 am, Michal Marek <[email protected]> wrote: > > Hi, > > I posted a rebased version of my patch to add parallel scanning to > clamscan here: > > https://github.com/vrtadmin/clamav-devel/pull/78 > > As I haven't received any feedback on the first version I posted last > year, could somebody please have a look and comment this time? Even a > "clamscan is a test tool and we do not care about its performance" would > suffice, but I would of course love to see the patch merged. The > motivation for writing it was that we use clamscan in our build > environment. It's simpler to use than setting up a one-shot clamd & > clamdscan, except for the lack of "multiscan" in clamscan. > > Thanks, > Michal > _______________________________________________ > http://lurker.clamav.net/list/clamav-devel.html > Please submit your patches to our Bugzilla: http://bugs.clamav.net > > http://www.clamav.net/contact.html#ml _______________________________________________ http://lurker.clamav.net/list/clamav-devel.html Please submit your patches to our Bugzilla: http://bugs.clamav.net http://www.clamav.net/contact.html#ml