Code style with commit ffa31264a657618a0e40c51c01e4bfc32e244d13

Shawn Webb <[email protected]> Thu, 20 Jul 2017 14:36:44 -0400

Newsgroups	gmane.comp.security.virus.clamav.devel
Message-ID	<20170720183644.qsx4uj2xpocam3mt@mutt-gmail>

Hey ClamAV Developers,

The part of the diff that reads:

if ( !(len = sys->read(fh, &buf[0], 256) > 0)) {

is a little awkward. I'm wondering if it would be better to be split
out. Something like this:

len = sys->read(fh, buf, sizeof(buf));
if (len <= 0) {
...
}

That would make the code a bit more readable for future developers. It
would also prevent issues in case the size of buf were to ever change in
the future.

Thanks,

-- 
Shawn Webb
Cofounder and Security Engineer of HardenedBSD

GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE

_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

http://www.clamav.net/contact.html#ml

signature.asc (application/pgp-signature, 833 B)