Re: Adding extra functionality to dll

Hi Micah,
  Actually I think I did the pull request.  I never have luck with github but I gave it a go.  I hope it got there.  Interestingly the numbers were different as there was a new EXPORT from the local copy I have.  That is, the numbers are now
    EXPORTS cl_fmap_open_handle @73
    EXPORTS cl_fmap_close @74
    EXPORTS cl_scanmap_callback @75

Ciao
Brett


-----Original Message-----
From: clamav-devel <[email protected]> On Behalf Of Micah Snyder (micasnyd)
Sent: Friday, 12 June 2020 6:34 AM
To: ClamAV Development <[email protected]>
Subject: Re: [Clamav-devel] Adding extra functionality to dll

Brett,

Yes!  I'm surprised those aren't already in there.  They certainly should be!  Would you like to submit a PR on our github mirror with the fix?

-Micah

On 6/10/20, 10:43 PM, "clamav-devel on behalf of Brett Hunter" <[email protected] on behalf of [email protected]> wrote:

    Hi,

      Is it possible for 3 lines to be added to the libclamav.def file for the
    Windows dll creation?  The lines being:



    EXPORTS cl_fmap_open_handle @72

    EXPORTS cl_fmap_close @73

    EXPORTS cl_scanmap_callback @74



    It makes it so scans can be done on memory buffers and streams.



    Sorry I posted this to the clam-users list but thought this might be a
    better place to discuss.



    Thanks

    Brett



    _______________________________________________

    clamav-devel mailing list
    [email protected]
    https://lists.clamav.net/mailman/listinfo/clamav-devel

    Please submit your patches to our Github: https://github.com/Cisco-Talos/clamav-devel/pulls

    Help us build a comprehensive ClamAV guide:
    https://github.com/vrtadmin/clamav-faq

    http://www.clamav.net/contact.html#ml

_______________________________________________

clamav-devel mailing list
[email protected]
https://lists.clamav.net/mailman/listinfo/clamav-devel

Please submit your patches to our Github: https://github.com/Cisco-Talos/clamav-devel/pulls

Help us build a comprehensive ClamAV guide:
https://github.com/vrtadmin/clamav-faq

http://www.clamav.net/contact.html#ml

_______________________________________________

clamav-devel mailing list
[email protected]
https://lists.clamav.net/mailman/listinfo/clamav-devel

Please submit your patches to our Github: https://github.com/Cisco-Talos/clamav-devel/pulls

Help us build a comprehensive ClamAV guide:
https://github.com/vrtadmin/clamav-faq

http://www.clamav.net/contact.html#ml