Re: Bug report

Rainer,

thanks for the answer.

Meanwhile I have looked into the source and found some bugs concering
the Lrufiles list. I am currently testing a new version, but I do not
yet know if it works - but it looks so.

Here is the current patch:

  http://www.daneben.de/tmp/samba-vscan-0.3.4-fix.patch

I have created a new static function which deletes a single item from
the list, given a pointer to the item, and replaces some
'DLIST_REMOVE()' etc. sequences by this function call. Two problems
are fixed: (a) The lrufiles_count counter was not decremented in every
case when an element was removed from the list and (b) there had been
uses to ZERO_STRUCT() with a pointer argument where ZERO_STRUCTP()
would have been correct.

Greetings,
Moritz



Du schreibst mir am Donnerstag, 6. November 2003:

> Moritz Both wrote:

> [..]
>> [2003/11/04 12:26:54, 10]
>> global/vscan-fileaccesslog.c:lrufiles_add(132)
>>   alloc space for file entry '/home/moritz/TheBat/The Bat Mail/ACCOUNT.LOG'
>> [2003/11/04 12:26:54, 10]
>> global/vscan-fileaccesslog.c:lrufiles_add(145)
>>   lru maximum reached '100'
>> [2003/11/04 12:26:54, 0] lib/fault.c:fault_report(38)
>>   ===============================================================
>> [2003/11/04 12:26:54, 0] lib/fault.c:fault_report(39)
>>   INTERNAL ERROR: Signal 11 in pid 3888 (2.2.7-security-rollup-fix)
>>   Please read the file BUGS.txt in the distribution
>> [2003/11/04 12:26:54, 0] lib/fault.c:fault_report(41)
>>   ===============================================================
>> [2003/11/04 12:26:54, 0] lib/util.c:smb_panic(1094)
>>   PANIC: internal error

> Looks like a bug in vscan-fileaccesslog.c, to be more precise when
> lru list reached the maximum.

> [..]

>> Note that when we comment the "vfs object =" lines and thus disable
>> the scanning, the error never appears. This is why we believe that
>> samba-vscan is probably the cause.
> Most likely, yes.


> [..]
>> ; as Windows tries to open a file multiple time in a (very) short time
>> ; of period, samba-vscan use a last recently used file mechanism to avoid
>> ; multiple scans of a file. This setting specified the maximum number of
>> ; elements of the last recently used file list. If set to 0, this
>> ; mechanism is disabled completely (default: 100)
>> max lru files entries = 100

> Could you please set this setting to zero (0) and see whether smbd 
> crashes or not?

> I'll have a closer look at this issue tomorrow, hopefully. Thanks for
> the detailed report.

> best regards,
> Rainer Link



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/