[serendipity-cvs] [s9y/Serendipity] 3b8cea: XML/RPC: Fix spl_object_hash parser conversion (#875)

onli via php-blog-cvs <[email protected]> Mon, 10 Mar 2025 08:24:33 -0700

Newsgroups	gmane.comp.serendipity.cvs
Message-ID	<s9y/Serendipity/push/refs/heads/master/[email protected]>

  Branch: refs/heads/master
  Home:   https://github.com/s9y/Serendipity
  Commit: 3b8cead4537ccadedf6f002f3f7d0ab2ed516ac7
      https://github.com/s9y/Serendipity/commit/3b8cead4537ccadedf6f002f3f7d0ab2ed516ac7
  Author: onli <[email protected]>
  Date:   2025-03-10 (Mon, 10 Mar 2025)

  Changed paths:
    M bundled-libs/XML/RPC.php
    A tests/include/bundledLibsTest.php
    M tests/include/functionsTest.php

  Log Message:
  -----------
  XML/RPC: Fix spl_object_hash parser conversion (#875)

* Replace (int) parser conversion with spl_object_hash
The (int) conversion does not work anymore since PHP 8 changed the xml parser from being a resource to being an object. Hardcoding it to a number, the initial fix, destroys the logic of having multiple parsers available and was not done everywhere. The object hash approach should be a valid replacement.

* Add test for XML_RPC_Message

* Add test for XML_RPC_Response, when valid

* Add test for invalid XML_Response, simplify code

* Fix $message access

* Try test fix for PHP 7.4

* Try test for PHP 7.4, LANG-CHARSET missing

* PHP 7.4 bc fix for XML_PARSER hash

* Try PHP 7.4 'ha' fix

* Try fix for undefined 'ha' index

* Use ?? check for legibility

Co-authored-by: Garvin Hicking <[email protected]>

---------

Co-authored-by: Garvin Hicking <[email protected]>



To unsubscribe from these emails, change your notification settings at https://github.com/s9y/Serendipity/settings/notifications