[serendipity-cvs] [s9y/Serendipity] 9b6e40: Let browser pin down cookie domain (#958)

onli via php-blog-cvs <[email protected]> Wed, 08 Apr 2026 01:28:54 -0700

Newsgroups	gmane.comp.serendipity.cvs
Message-ID	<s9y/Serendipity/push/refs/heads/master/[email protected]>

  Branch: refs/heads/master
  Home:   https://github.com/s9y/Serendipity
  Commit: 9b6e405892c5d627780a81373c7b968fda754d49
      https://github.com/s9y/Serendipity/commit/9b6e405892c5d627780a81373c7b968fda754d49
  Author: onli <[email protected]>
  Date:   2026-04-08 (Wed, 08 Apr 2026)

  Changed paths:
    M docs/NEWS
    M include/functions_config.inc.php

  Log Message:
  -----------
  Let browser pin down cookie domain (#958)

* Fix attack vector by not using HTTP_HOST for the cookie domain
Instead use the configurable baseURL.

* Do not set a domain manually for the cookie
Then the browser will autoamtically bind the cookie to the origin, which is the safest approach. See https://cheatsheetseries.owasp.org/cheatsheets/Session_Management_Cheat_Sheet.html#domain-and-path-attributes

* Also avoid host in delete cookie function + remove leftover code

* document changes



To unsubscribe from these emails, change your notification settings at https://github.com/s9y/Serendipity/settings/notifications