[ php-blog-Bugs-1700319 ] Partial RSS feeds broken

Bugs item #1700319, was opened at 2007-04-13 20:25
Message generated for change (Comment added) made by garvinhicking
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=1700319&group_id=75065

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Syndication Feeds
Group: None
>Status: Pending
>Resolution: Remind
>Priority: 2
Private: No
Submitted By: John Goerzen (jgoerzen)
>Assigned to: Garvin Hicking (garvinhicking)
Summary: Partial RSS feeds broken

Initial Comment:
This is breaking interaction with planet.

s9y's handling of partial rss feeds (detecting what to send based on the http request) is broken because it looks at the story date, not at the actual date the item was flipped from draft to published (or created in published state).  This causes some items to be omitted if the entry date is enough older than the date it was made publically available.

This diff is a workaround:

--- a/rss.php   Tue Mar 13 23:06:40 2007 -0500
+++ b/rss.php   Fri Apr 13 15:20:45 2007 -0500
@@ -103,7 +103,7 @@ default:
         // Fetch all entries in reverse order for later importing. Fetch sticky entries as normal entries.
         $entries = serendipity_fetchEntries(null, true, '', false, false, 'id ASC', '', false, true);
     } else {
-        $entries = serendipity_fetchEntries(null, true, $serendipity['RSSfetchLimit'], false, (isset($modified_since) ? $modified_since : false), 'timestamp DESC', '', false, true);
+        $entries = serendipity_fetchEntries(null, true, $serendipity['RSSfetchLimit'], false, false, 'timestamp DESC', '', false, true);
     }
     break;
 }


----------------------------------------------------------------------

>Comment By: Garvin Hicking (garvinhicking)
Date: 2007-04-14 10:32

Message:
Logged In: YES 
user_id=473563
Originator: NO

Hi!

Did you have a look at the option "Activate strict RFC2616 RSS-Feed
compliance" of the syndication plugin?

Planets send a strange mixture of Last-Modified headers and can't properly
deal with the s9y output and unify articles. The option above was created
for those planets.

You might also want to submit your RSS-feed URLs to planets using the
?nocache=true option?

HTH,
Garvin

----------------------------------------------------------------------

Comment By: John Goerzen (jgoerzen)
Date: 2007-04-13 20:32

Message:
Logged In: YES 
user_id=491567
Originator: YES

I may have mis-guessed the cause; the actual problem could be earlier
where there is a 304 returned.  Or perhaps both are occuring.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=1700319&group_id=75065

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV