[ php-blog-Bugs-1922509 ] xmlrpc doesn't comply to MetaWeblog API

Bugs item #1922509, was opened at 2008-03-21 20:12
Message generated for change (Settings changed) made by garvinhicking
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=1922509&group_id=75065

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Plugins
Group: None
>Status: Pending
>Resolution: Fixed
>Priority: 1
Private: No
Submitted By: Sven Herzberg (herzi)
>Assigned to: Garvin Hicking (garvinhicking)
Summary: xmlrpc doesn't comply to MetaWeblog API

Initial Comment:
From http://www.xmlrpc.com/metaWeblogApi#metaweblognewmediaobject:

»...
The struct must contain at least three elements, name, type and bits.
...
bits is a base64-encoded binary value containing the content of the object.
...«

S9y doesn't base64_decode() the data before writing. Is this intentioal or a bug? If it is intentional, I can develop a patch to detect base64-decoded data, otherwise I'd only provide a fixing patch. Just tell me which patch you'd like to see.

----------------------------------------------------------------------

>Comment By: Garvin Hicking (garvinhicking)
Date: 2008-03-25 08:42

Message:
Logged In: YES 
user_id=473563
Originator: NO

Hi!

Sorry for taking me some time; I've just committed your patch, many thanks
for your contribution!

Best regards,
Garvin

----------------------------------------------------------------------

Comment By: Sven Herzberg (herzi)
Date: 2008-03-22 15:15

Message:
Logged In: YES 
user_id=76622
Originator: YES

Anyway, attaching the patch; wouldn't be much work to split it anyways.
File Added: serendipity-plugin-xmlrpc--base64-decode.patch

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-03-22 15:09

Message:
Logged In: NO 

Wow, it's been a long time since I wrote the last line of php, just please
tell me if this is okay to write:

if ($decoded = base64_decode ($struct['bits'])) {
    $struct['bits'] = $decoded;
}

Or will I have to split the assignment and the if() into separate lines?

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)
Date: 2008-03-22 10:09

Message:
Logged In: YES 
user_id=473563
Originator: NO

Hi!

Hm, I think i've heard from people who successfully can upload images to
s9y - so I wonder if different clients maybe send the data binary?

Either way, a patch would be appreciated - I think it's best if
base64encoded data could be detected?

Regards,
Garvin

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=1922509&group_id=75065

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
php-blog-tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/php-blog-tracker