Re: [PATCH] mapfile: improve array lookup w/ callback

Chet Ramey <[email protected]> Thu, 4 Jun 2026 10:26:50 -0400

Newsgroups	gmane.comp.shells.bash.bugs
Organization	ITS, Case Western Reserve University
Message-ID	<[email protected]>

On 6/3/26 7:06 PM, Grisha Levit wrote:
> Latest commit to the devel branch changed mapfile to always look up the
> array by name for the benefit of callbacks that modify the variable.
> Looks like now it does the less efficient lookup on every loop iteration
> regardless of the callback having been called (or configured) and also
> still does the assignment with the previous method.

Thanks for the report. The diff (and bash-5.3 patch) was incomplete; I
wouldn't have left the call to bind_array_element in there otherwise. This
is the right fix.

Chet
-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    [email protected]    http://tiswww.cwru.edu/~chet/

OpenPGP_signature.asc (application/pgp-signature, 203 B)