Re: [PATHC] Fix handling of reversed slices in assignstrvalue
Philippe Altherr <[email protected]>
| Newsgroups | gmane.comp.shells.zsh.devel |
|---|---|
| Message-ID | <CAGdYchuzpOUU3Kpem2dAABxGc7+qa7OYn2uGjs2tn3gKhNS5hw@mail.gmail.com> |
> > Thanks, that makes sense. I guess this is somewhat an argument to keep > the first hunk too, it's more of a statement that v->end is < zlen, > Although, now that the else if is gone, the same is expressed by the last test, i.e., the first hunk kind of becomes doubly redundant. Another reason I removed it is because it's not present in the equivalent code for arrays in setarrvalue <https://github.com/zsh-users/zsh/blob/e73499b372c398c1043b12955c3b3e7602b1a992/Src/params.c#L2939-L2955>. In workers/54348 <http://zsh.org/workers/54348>, I unify the code for strings and arrays. If you keep the first hunk, I might add an equivalent one for arrays in that patch. Philippe