Re: PATCH 1/3: Fix buffer overflow and wrong behavior in url_encode

Philippe Altherr <[email protected]> Thu, 7 May 2026 11:35:05 +0200

Newsgroups	gmane.comp.shells.zsh.devel
Message-ID	<CAGdYchu_q0Y+_+ijt=OSkkRJCFO4kU1Q7q2svzZyGv=tSUcPcQ@mail.gmail.com>

"const unsigned char *in" looks very weird to me. Wouldn't it be possible
to cast "*in" in the call to sprintf:

out += sprintf(out, "%%%02X", (unsigned char)*in);

or maybe

out += sprintf(out, "%%%02X", *in & 0xFF);

Philippe

lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.