Re: [PATCH] completion: add _uids, _gids

On Tue 14 Jul 2026, at 18:24, Oliver Kiddle wrote:
> That's fine. I think we can do better for -Nu where both forms are
> matched (such as with empty $PREFIX) - sorting them together but adding
> both as matches. While -Nu offers both, where both are valid, it'd
> mostly be better if UIDs were only a fallback.

you're suggesting that with -Nu we should only offer the uids when
$PREFIX == [0-9-]* basically? i could do that

On Tue 14 Jul 2026, at 18:24, Oliver Kiddle wrote:
> You are missing && ret=0 from _describe so it doesn't stop at the
> _complete completer.

oops. fixed

On Tue 14 Jul 2026, at 18:24, Oliver Kiddle wrote:
> The main purpose
> of _describe is its ability to combine matches that share a common
> description. Even with short matches/descriptions, that's easily too
> long for columns to work.

i forgot about that, but fwiw i think it's easily solved by just not
passing the -g to compdescribe -I

On Tue 14 Jul 2026, at 18:24, Oliver Kiddle wrote:
> Next _describe does not do a good job of accepting more unusual compadd
> options like -A, -D. It even conflicts for -O.

they seem to work for me generally i think? how do you mean?

On Tue 14 Jul 2026, at 18:24, Oliver Kiddle wrote:
> Given the need to check the separator style and the fact
> that we often go to the effort of aligning separators, I wouldn't argue
> against factoring much of this out into a simpler helper. But I think
> we can improve on the interface provided by _describe and support the
> full gamut of compadd options. Perhaps a helper like _description that
> populates an array with options, doesn't do a tags/labels loop and
> leaves you to call compadd.

like it'd build the display + insert arrays and then just give them back
to you (with expl)? when wouldn't you want to pass those straight on to
compadd?

On Tue 14 Jul 2026, at 18:24, Oliver Kiddle wrote:
> Most commands that want raw UIDs are fairly low-level system stuff so
> I'm not sure how useful that is.

k, removed that bit

On Tue 14 Jul 2026, at 18:24, Oliver Kiddle wrote:
> I have vague memories that it may need to be ypcat passwd.byname

that's what i used yeah

ty for looking again

dana