Re: SAML 1.1 toolkit 2.0
Bryan Field-Elliot <[email protected]> Fri, 18 Feb 2005 05:51:54 -0700
| Newsgroups | gmane.comp.sourceid.sso.user |
|---|---|
| Message-ID | <[email protected]> |
--===============2012948881==
Content-Type: multipart/alternative; boundary="=-igiG62ohMdrNpMl8VemQ"
--=-igiG62ohMdrNpMl8VemQ
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
On Fri, 2005-02-18 at 12:11 +0100, Garzon Maldonado, Jesus Javier wrote:
> Probably it's already fixed but I think I've found a small mistake in
> org.sourceid.saml11.servlet.rp.AssertionConsumerServlet class.
>
> Line 182: if ( (localPort != 443) || (localPort != 80) )
>
> OR operator should be changed for AND:
>
> if ( (localPort != 443) && (localPort != 80) )
>
Javi, you are right! The expression as written will always evaluate to
"true" (which is not a very useful "if" statement, is it?). Your
correction is correct -- it should be a logical AND. Thanks for
reporting this bug.
The effect of this bug is that through some paths of the system, the
port number will always be appended to the URL, even though this is not
required if the port is a standard (80 or 443). With the bug fix,
SourceID will drop the port number out of the URL when it can.
Thank you,
Bryan Field-Elliot
Ping Identity Corporation
--=-igiG62ohMdrNpMl8VemQ
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.3.2">
</HEAD>
<BODY>
On Fri, 2005-02-18 at 12:11 +0100, Garzon Maldonado, Jesus Javier wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<FONT SIZE="2"><FONT COLOR="#000000">Probably it's already fixed but I think I've found a small mistake in org.sourceid.saml11.servlet.rp.AssertionConsumerServlet class. </FONT></FONT><BR>
<FONT COLOR="#000000"> </FONT><BR>
<FONT SIZE="2"><FONT COLOR="#000000">Line 182: </FONT></FONT><B><FONT SIZE="2"><FONT COLOR="#7f0055">if</FONT></FONT></B><FONT SIZE="2"><FONT COLOR="#000000"> ( (localPort != 443) || (localPort != 80) )</FONT></FONT><BR>
<FONT COLOR="#000000"> </FONT><BR>
<FONT SIZE="2"><FONT COLOR="#000000">OR operator should be changed for AND: </FONT></FONT><BR>
<FONT COLOR="#000000"> </FONT><BR>
<B><FONT SIZE="2"><FONT COLOR="#7f0055">if</FONT></FONT></B><FONT SIZE="2"><FONT COLOR="#000000"> ( (localPort != 443) && (localPort != 80) )</FONT></FONT><BR>
<FONT COLOR="#000000"> </FONT><BR>
</BLOCKQUOTE>
<BR>
Javi, you are right! The expression as written will always evaluate to "true" (which is not a very useful "if" statement, is it?). Your correction is correct -- it should be a logical AND. Thanks for reporting this bug.<BR>
<BR>
The effect of this bug is that through some paths of the system, the port number will always be appended to the URL, even though this is not required if the port is a standard (80 or 443). With the bug fix, SourceID will drop the port number out of the URL when it can.<BR>
<BR>
Thank you,<BR>
<BR>
Bryan Field-Elliot<BR>
Ping Identity Corporation<BR>
<BR>
<BR>
</BODY>
</HTML>
--=-igiG62ohMdrNpMl8VemQ--
--===============2012948881==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
sso-users mailing list
[email protected]
http://lists.sourceid.org/mailman/listinfo/sso-users
--===============2012948881==--