"ID-FF 1.2 Java Toolkit 2.0 Beta": configuration problems, fixed bugs

"Hiller, Jochen" <[email protected]> Wed, 9 Mar 2005 08:55:24 +0100
Newsgroups gmane.comp.sourceid.sso.user
Message-ID <[email protected]>
Hello all,

we are using the "ID-FF 1.2 Java Toolkit 2.0 Beta", and detected two =
bugs in
configuration classes:

1. NullPointerException in =
ProviderDirectoryXMLFileImpl.getSignatureKey()

When an entry for a private key password ist missing in
"sourceid-core-config.xml", a NullPointerException will occur. It would =
be
better to throw a configuration exception instead.

--- bugfix in ProviderDirectoryXMLFileImpl ---
            String keyPassStr =3D =
CoreConfig.getPrivateKeyPassword(keyAlias);
            // Fixed by Jochen Hiller
            if (keyPassStr =3D=3D null) {
                throw new ConfigurationException(
                     "Can't retrieve specified private key " + keyAlias
                     + ": could not get private key password from"
                     + " core config file");
            }

            char[] keypass =3D keyPassStr.toCharArray();
            ...
--- bugfix ---


2. List of private key passwords in sourceid-core-config.xml will not be
read in, only first entry


--- bugfix in BasicXMLConfigStore.reload() ---
            for (int j =3D 0; j < mapItems.length; j++)
            {
                // Fixed by Jochen Hiller: use j and not i
                ItemType item =3D mapItems[j];
                map.put(item.getName(), item.getStringValue());
            }
--- bugfix ---


I wrote some test cases to check the correct functionality. To whom =
should I
send the test cases ? Developers list or Bryan Field-Elliot directly ?


Bye, Jochen Hiller