metadata: vorbis: fix warning when building sim on aarch64 linux
rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]>
| Newsgroups | gmane.comp.systems.archos.rockbox.cvs |
|---|---|
| Message-ID | <[email protected]> |
commit 4541c94292a00fb8d5e9541a9358d0831b1e5000 Author: Christian Soffke <[email protected]> Date: Sun Jan 11 15:27:40 2026 +0100 metadata: vorbis: fix warning when building sim on aarch64 linux b64_codes is unsigned on some systems unless explicitly declared as signed. "b64_codes[index] < 0 comparison is always false due to limited range of data type [-Werror=type-limits]" Introduced in 849e8ab Change-Id: I6a86e898c2ed8995f7346060f9b9b58ea6ab1e95 diff --git a/lib/rbcodec/metadata/vorbis.c b/lib/rbcodec/metadata/vorbis.c index 3c7b764bf0..9e4381c643 100644 --- a/lib/rbcodec/metadata/vorbis.c +++ b/lib/rbcodec/metadata/vorbis.c @@ -293,7 +293,7 @@ bool ogg_file_init(struct ogg_file* file, int fd, int type, int remaining) #define B64_START_CHAR '+' /* maps char codes to BASE64 codes ('A': 0, 'B': 1,... '+': 62, '-': 63 */ -const char b64_codes[] = +const signed char b64_codes[] = { /* Starts from first valid base 64 char '+' with char code 43 (B64_START_CHAR) * For valid base64 chars: index in 0..63; for invalid: -1, for =: -2 */ 62, -1, -1, -1, 63, /* 43-47 (+ /) */ -- rockbox-cvs mailing list [email protected] https://lists.haxx.se/mailman/listinfo/rockbox-cvs