devinput: Fix regression on Hiby R1

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]>
Newsgroups gmane.comp.systems.archos.rockbox.cvs
Message-ID <[email protected]>
commit 8d15aff38ac5649c48bebda94693c03ca0627772
Author: Solomon Peachy <[email protected]>
Date:   Sun Jan 18 07:44:48 2026 -0500

    devinput:  Fix regression on Hiby R1
    
    3a4da9381eccf62 change an underdocumented definition that turns
    out to be important, yet not documented in the linux uapi definitions.
    
    Revert that change, and document the magic values so this doesn't happen again.
    
    Change-Id: I0fac4a9d68170920bb5db1018d765e8a2994a95f

diff --git a/firmware/target/hosted/button-devinput.c b/firmware/target/hosted/button-devinput.c
index 343f1a4fe8..a9129f3ea6 100644
--- a/firmware/target/hosted/button-devinput.c
+++ b/firmware/target/hosted/button-devinput.c
@@ -105,9 +105,10 @@ static enum
     TOUCHSCREEN_STATE_DOWN
 } _last_touch_state = TOUCHSCREEN_STATE_UNKNOWN;
 
-// XXX ... figure out what is standard.
+/* Do _NOT_ change this.  Unofficial Linux API */
+#define EVENT_VALUE_TOUCHSCREEN_RELEASE  -1
+/* This is only used as an arbitrary placeholder */
 #define EVENT_VALUE_TOUCHSCREEN_PRESS    1
-#define EVENT_VALUE_TOUCHSCREEN_RELEASE  0
 
 static int ts_enabled = 1;
 
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.