misc: Correct inifinite loop when volume has a fractional component

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]>
Newsgroups gmane.comp.systems.archos.rockbox.cvs
Message-ID <[email protected]>
commit 78778d6e6f3aa3ff2ff0e95dc37994f9f3560300
Author: Solomon Peachy <[email protected]>
Date:   Mon Feb 2 08:20:21 2026 -0500

    misc:  Correct inifinite loop when volume has a fractional component
    
    Introduced in 3f2ca2024
    
    Purely a theretical problem but we should fix it regardless
    
    Change-Id: Ifeb4e1aeb3291c723b2addf2f2d391775db57b03

diff --git a/apps/misc.c b/apps/misc.c
index 5c3d457d54..05f1fa6a93 100644
--- a/apps/misc.c
+++ b/apps/misc.c
@@ -1959,7 +1959,7 @@ static long get_nvol_factor(void)
         factor /= 10;
 
     /* nothing *actually* needs this, but: */
-    while (numdecimals > 1)
+    while (numdecimals-- > 1)
         factor *= 10;
 
     return factor;
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.