FS#13802 - Correct untranslated menu headings in mpegplayer

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Mon, 6 Apr 2026 08:13:36 -0400
Newsgroups gmane.comp.systems.archos.rockbox.cvs
Message-ID <[email protected]>
commit d82d0be5950bc995850859383d3b148f051220fc
Author: Solomon Peachy <[email protected]>
Date:   Mon Apr 6 08:08:48 2026 -0400

    FS#13802 - Correct untranslated menu headings in mpegplayer
    
    Every menu heading except the top-level "MPEG Player" (ie the name of
    the plugin) now uses pre-existing translated strings.
    
    Change-Id: I65ee64ddc537be4947872da4757bc2f6a27d0bae

diff --git a/apps/plugins/mpegplayer/mpeg_settings.c b/apps/plugins/mpegplayer/mpeg_settings.c
index 58dc11c89a..3dc621d2e9 100644
--- a/apps/plugins/mpegplayer/mpeg_settings.c
+++ b/apps/plugins/mpegplayer/mpeg_settings.c
@@ -1148,7 +1148,7 @@ static void display_options(void)
     int result;
     bool menu_quit = false;
 
-    MENUITEM_STRINGLIST(menu, "Display Options", mpeg_sysevent_callback,
+    MENUITEM_STRINGLIST(menu, ID2P(LANG_MENU_DISPLAY_OPTIONS), mpeg_sysevent_callback,
 #if MPEG_OPTION_DITHERING_ENABLED
                         ID2P(LANG_DITHERING),
 #endif
@@ -1225,7 +1225,7 @@ static void audio_options(void)
     int result;
     bool menu_quit = false;
 
-    MENUITEM_STRINGLIST(menu, "Audio Options", mpeg_sysevent_callback,
+    MENUITEM_STRINGLIST(menu, ID2P(LANG_MENU_AUDIO_OPTIONS), mpeg_sysevent_callback,
                         ID2P(LANG_TONE_CONTROLS),
                         ID2P(LANG_CHANNEL_CONFIGURATION),
                         ID2P(LANG_CROSSFEED),
@@ -1311,7 +1311,7 @@ static void mpeg_settings(void)
     int result;
     bool menu_quit = false;
 
-    MENUITEM_STRINGLIST(menu, "Settings", mpeg_sysevent_callback,
+    MENUITEM_STRINGLIST(menu, ID2P(LANG_SETTINGS), mpeg_sysevent_callback,
                         ID2P(LANG_MENU_DISPLAY_OPTIONS),
                         ID2P(LANG_MENU_AUDIO_OPTIONS),
                         ID2P(LANG_MENU_RESUME_OPTIONS),
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs