ipod4g: Pull LCD framebuffer out of IRAM

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Tue, 14 Apr 2026 11:04:11 -0400
Newsgroups gmane.comp.systems.archos.rockbox.cvs
Message-ID <[email protected]>
commit 41893b250f18c1be2f20c3d4fa4521fee088a34e
Author: Solomon Peachy <[email protected]>
Date:   Tue Apr 14 10:16:58 2026 -0400

    ipod4g:  Pull LCD framebuffer out of IRAM
    
    The recent pcm_mixer changes caused us to overflow IRAM by a whopping 8
    bytes.  This can _probably_ be mitigated with some clever reworking but
    we were clearly already on the hairy edge.
    
    Future pending changes are likely to increase IRAM pressure so even if
    we solve this issue the odds are it will reappear at a future point.
    
    (the ipod4g's framebuffer is 5KB.  This doesn't affect the mini2g as its
     framebuffer is under 4KB, and the ipodcolor doesn't put its framebuffer
     in IRAM at all)
    
    Change-Id: I2f50d998e969a706cc9d3a0e057cf8e6c303c9b4

diff --git a/firmware/export/config/ipod4g.h b/firmware/export/config/ipod4g.h
index 65b14d0ad2..ee74ba8e14 100644
--- a/firmware/export/config/ipod4g.h
+++ b/firmware/export/config/ipod4g.h
@@ -220,7 +220,7 @@
 #define HAVE_IAP_MULTIPORT
 #define HAVE_SERIAL
 
-#define IRAM_LCDFRAMEBUFFER IBSS_ATTR /* put the lcd frame buffer in IRAM */
+// #define IRAM_LCDFRAMEBUFFER IBSS_ATTR /* put the lcd frame buffer in IRAM */
 
 
 /* DMA is used only for reading on PP502x because although reads are ~8x faster
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs