Revert "pp5020: ata: do not yield in ata_wait_intrq()"

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Thu, 14 May 2026 14:42:54 -0400

Newsgroups	gmane.comp.systems.archos.rockbox.cvs
Message-ID	<[email protected]>

commit 4c60fe95fc88fa8ae7ac9dc7f5a84f9e6f3f4aca
Author: Solomon Peachy <[email protected]>
Date:   Wed May 13 06:58:37 2026 -0400

    Revert "pp5020: ata: do not yield in ata_wait_intrq()"
    
    This reverts commit e13befb9258391056891b332955ca01e1714c834.
    
    Reason for revert:  Significant performance regressions, especially with respect to UI interactivity when the database is in use; see https://forums.rockbox.org/index.php/topic,55703.0.html
    
    Change-Id: I0428711871480b74f7faeecb0536f7ed63f631cc

diff --git a/firmware/target/arm/pp/ata-pp5020.c b/firmware/target/arm/pp/ata-pp5020.c
index 3850f34fb1..7351215693 100644
--- a/firmware/target/arm/pp/ata-pp5020.c
+++ b/firmware/target/arm/pp/ata-pp5020.c
@@ -154,6 +154,7 @@ static ICODE_ATTR int ata_wait_intrq(void)
         if (IDE0_CFG & IDE_CFG_INTRQ)
             return 1;
         ata_keep_active();
+        yield();
     } while (TIME_BEFORE(current_tick, timeout));
 
     return 0; /* timeout */
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs