plugins: text_editor: fix list items that continue to scroll (FS#13900)
rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Tue, 19 May 2026 12:20:12 -0400
| Newsgroups | gmane.comp.systems.archos.rockbox.cvs |
|---|---|
| Message-ID | <[email protected]> |
commit 29d62e933f6501abda8a5a0b472afd61399f5ba6 Author: Christian Soffke <[email protected]> Date: Tue May 19 16:57:38 2026 +0200 plugins: text_editor: fix list items that continue to scroll (FS#13900) When using a theme with custom skinned lists (e.g. Themify 2), a line in Text Editor will continue to scroll after opening the context menu, because you're switching from an un- skinned list to a skinned list, which means that list-skinned.c/list_draw isn't calling scroll_stop_viewport for the list_text_vp, as would be the case for un-skinned lists. Change-Id: I952937166d8f17c9d57f4d93e715de970c49e5e8 diff --git a/apps/plugins/text_editor.c b/apps/plugins/text_editor.c index 60ddb23466..48a35e9c08 100644 --- a/apps/plugins/text_editor.c +++ b/apps/plugins/text_editor.c @@ -522,6 +522,7 @@ enum plugin_status plugin_start(const void* parameter) case ACTION_STD_MENU: #endif { + rb->gui_synclist_scroll_stop(&lists); /* do the item menu */ switch (do_item_menu(cur_sel)) { @@ -540,6 +541,7 @@ enum plugin_status plugin_start(const void* parameter) case ACTION_STD_CANCEL: if (changed) { + rb->gui_synclist_scroll_stop(&lists); MENUITEM_STRINGLIST(menu, "Text Editor", NULL, "Return", "Playback Control", "Save Changes", -- rockbox-cvs mailing list [email protected] https://lists.haxx.se/mailman/listinfo/rockbox-cvs