lcd: Fix possible unset-before-use variable in 4bit alpha blending

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Mon, 25 May 2026 13:07:24 -0400

Newsgroups	gmane.comp.systems.archos.rockbox.cvs
Message-ID	<[email protected]>

commit ff3155be9a03886067c3c8a6878a6b6adbd1a44a
Author: Solomon Peachy <[email protected]>
Date:   Mon May 25 13:05:49 2026 -0400

    lcd:  Fix possible unset-before-use variable in 4bit alpha blending
    
    Change-Id: I39e779e9452239b00731f31f55225cd979afe911

diff --git a/firmware/drivers/lcd-16bit-common.c b/firmware/drivers/lcd-16bit-common.c
index 6108832cb4..c896e50545 100644
--- a/firmware/drivers/lcd-16bit-common.c
+++ b/firmware/drivers/lcd-16bit-common.c
@@ -508,6 +508,8 @@ static void ICODE_ATTR lcd_alpha_bitmap_part_mix(
         if (alpha_pixels) { \
             alpha_data = *alpha++ ^ dmask; \
             alpha_data >>= ALPHA_BPP; \
+        } else { \
+            alpha_data = 0; \
         } \
     } while(0)
 #define START_ALPHA() do { } while(0)
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs