Hack to fix ipodpatcher on macOS - ignore exit code from unmount

commit 53d2a99a2a4d522492fdcec0d48aa22b8fb72033
Author: Vencislav Atanasov <[email protected]>
Date:   Fri Jun 19 22:02:11 2026 +0300

    Hack to fix ipodpatcher on macOS - ignore exit code from unmount
    
    ipodpatcher tries to unmount volumes that are not mounted e.g. the firmware partition, before making any changes. On macOS this fails with a non-zero exit code, causing the whole process (bootloader installation or uninstallation) to fail.
    
    A proper fix would be to trace every path that uses ipod_reopen_rw(), and only call unmount if we expect the volume to be currently mounted.
    
    Change-Id: Ieaa58da336216d5060465cfc2b7f5f8c729fe8b9

diff --git a/utils/ipodpatcher/ipodio-posix.c b/utils/ipodpatcher/ipodio-posix.c
index cf1b3ddb2c..a9e3eaf2d3 100644
--- a/utils/ipodpatcher/ipodio-posix.c
+++ b/utils/ipodpatcher/ipodio-posix.c
@@ -338,8 +338,7 @@ int ipod_open(struct ipod_t* ipod, int silent)
 int ipod_reopen_rw(struct ipod_t* ipod)
 {
 #if defined(__APPLE__) && defined(__MACH__)
-    if (ipod_unmount(ipod) < 0)
-        return -1;
+    ipod_unmount(ipod);
 #endif
 
     close(ipod->dh);
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs